Skip to content

Changes in preparation for the 2.13 collections #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Mar 22, 2018

Changes uses of scala.Seq to collection.Seq, as in 2.13 the scala.Seq alias changes to be scala.immutable.Seq.

Some other changes that enable cross-building 2.11 ---> 2.13.

Also update the sbt-scala-module plugin.

@lrytz lrytz force-pushed the newCollectionsPartial branch from a46eb84 to 07ec0b0 Compare March 22, 2018 21:31
@SethTisue
Copy link
Member

I guess this would have to be a 1.2 release...?

@lrytz
Copy link
Member Author

lrytz commented Mar 22, 2018

This PR not, it's binary compatible.

@lrytz
Copy link
Member Author

lrytz commented Mar 22, 2018

Note that this PR doesn't allow building with the new collections yet, it just includes those changes that cross-build.

For the rest, there will be another PR once 2.13.0-M4 is out. These changes are here: https://github.com/scala/scala-xml/tree/newCollectionsBootstrap

@ashawley
Copy link
Member

The badges on the README are a little goofed up:

maven badges are screwy

@lrytz
Copy link
Member Author

lrytz commented Mar 29, 2018

sorry about the tags.. it just picks the most recent release.

@SethTisue
Copy link
Member

needs rebase

@ashawley
Copy link
Member

Yeah, sorry. We fixed procedure syntax warnings in #207.

@ashawley
Copy link
Member

Merged in #210

@ashawley ashawley closed this Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants